Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorial and unit test for LDOS of planar cavity with lossless metallic walls #2076

Merged
merged 4 commits into from
May 24, 2022

Conversation

oskooi
Copy link
Collaborator

@oskooi oskooi commented May 18, 2022

Adds a new tutorial ("Planar Cavity with Lossless Metallic Walls") and unit test based on the analytic results in IEEE J. Quantum Electronics, Vol. 34, pp. 71-76 (1998).

This replaces the existing unit test for the LDOS feature which just validated the simulated results against arbitrary, hard-coded values.

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2022

Codecov Report

Merging #2076 (d07d544) into master (5275f43) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2076   +/-   ##
=======================================
  Coverage   73.25%   73.25%           
=======================================
  Files          17       17           
  Lines        4902     4902           
=======================================
  Hits         3591     3591           
  Misses       1311     1311           
Impacted Files Coverage Δ
python/simulation.py 76.92% <0.00%> (ø)

@stevengj
Copy link
Collaborator

stevengj commented May 24, 2022

Two possible follow-up tests:

  1. You could try it in cylindrical coordinates.
  2. You could try it in a 1d simulation (along x), integrating the result over ky and kz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants